XiaoyiPeng commented on PR #4350: URL: https://github.com/apache/rocketmq/pull/4350#issuecomment-1135337506
@ni-ze , @HScarb , Thanks for your review. But IMO, For code consistency, I recommend not changing this method `ThreadLocalIndex#incrementAndGet()`, because this method is used in many places. In most scenarios, it determine whether the result returned is positive or negative after the call, as shown below:  And it we changing this method(`ThreadLocalIndex#incrementAndGet()`), The variable `index` it returned may still be a positive number, eg: `Integer.MAX_VALUE`. when `Math.abs(++index)` is called, we still need to judge if this value is negative, just looks like in the screenshot. Hi @panzhi33 , @RongtongJin what's your opinion? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
