cserwen commented on code in PR #906:
URL: https://github.com/apache/rocketmq-client-go/pull/906#discussion_r955865136
##########
consumer/pull_consumer.go:
##########
@@ -193,6 +201,14 @@ func (pc *defaultPullConsumer) Poll(ctx context.Context,
timeout time.Duration)
case <-ctx.Done():
return nil, ErrNoNewMsg
case cr := <-pc.consumeRequestCache:
+ if cr.GetPQ().IsDroppd() {
+ rlog.Info("defaultPullConsumer poll the message queue
not be able to consume, because it was dropped", map[string]interface{}{
Review Comment:
`GetPQ()` is unnecessary. Use `cr.processQueue` may be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
