[GitHub] [rocketmq] aaron-ai commented on a diff in pull request #5245: [ISSUE #4658] remove redundant logic

[GitBox]

aaron-ai commented on code in PR #5245:
URL: https://github.com/apache/rocketmq/pull/5245#discussion_r990583154


##########
client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java:
##########
@@ -348,11 +348,9 @@ public void run() {
                     try {
                         if (transactionCheckListener != null) {
                             localTransactionState = 
transactionCheckListener.checkLocalTransactionState(message);
-                        } else if (transactionListener != null) {
-                            log.debug("Used new check API in transaction 
message");
-                            localTransactionState = 
transactionListener.checkLocalTransaction(message);
                         } else {
-                            log.warn("CheckTransactionState, pick 
transactionListener by group[{}] failed", group);
+                            log.warn("TransactionCheckListener is null, used 
new check API, producerGroup={}", group);

Review Comment:
   ```suggestion
                               log.debug("TransactionCheckListener is null, 
used new check API, producerGroup={}", group);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org