caigy commented on code in PR #4769:
URL: https://github.com/apache/rocketmq/pull/4769#discussion_r991754880
##########
docs/cn/acl/user_guide.md:
##########
@@ -30,6 +30,26 @@ ACL客户端可以参考：**org.apache.rocketmq.example.simple**包下面的**A
| defaultGroupPerm | DENY;PUB;SUB;PUB\|SUB | 默认的ConsumerGroup权限 |
| topicPerms | topic=权限 | 各个Topic的权限 |
| groupPerms | group=权限 | 各个ConsumerGroup的权限 |
Review Comment:
Add notes about deprecation of `topicPerms` and `groupPerms`, and their
successor `resourcePerms`.
##########
acl/src/main/java/org/apache/rocketmq/acl/AccessValidator.java:
##########
@@ -60,6 +63,38 @@ public interface AccessValidator {
*/
boolean updateAccessConfig(PlainAccessConfig plainAccessConfig);
+ /**
+ * Update the accessKey's secretKey whiteRemoteAddress admin
defaultTopicPerm and defaultGroupPerm
+ * @param plainAccessConfig
+ * @return
+ */
+ boolean updateAclAccount(PlainAccessConfig plainAccessConfig);
+
+ /**
+ * update the accessKey's resourcePerms
+ * @param accesskey
+ * @param resourceAndPerm
+ * @param operationType
+ * @return
+ */
+ boolean updateAclResourcePerms(String accesskey, ResourceAndPerm
resourceAndPerm, OperationType operationType);
+
+ /**
+ * update the accessKey's namespacePerms
+ * @param accesskey
+ * @param namespaceAndPerms
+ * @param operationType
+ * @return
+ */
+ boolean updateAclNamespacePerms(String accesskey, List<NamespaceAndPerm>
namespaceAndPerms, OperationType operationType);
+
+ /**
+ * get the accessKey's config
+ * @param accesskey
+ * @return
+ */
Review Comment:
IMO `PlainAccessConfig` is an implementation of ACL, it should be separated
from interface `AccessValidator`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
