lizhanhui commented on code in PR #5323:
URL: https://github.com/apache/rocketmq/pull/5323#discussion_r996550415


##########
common/src/main/java/org/apache/rocketmq/common/namesrv/NamesrvConfig.java:
##########
@@ -78,6 +78,9 @@ public class NamesrvConfig {
      */
     private boolean enableControllerInNamesrv = false;
 
+    private volatile boolean needWaitForService = true;
+
+    private int waitSecondsForService = 45;

Review Comment:
   Hard-coded value is not optimal, because users might adjust the interval of 
broker registration... Would it be better to set it to alpha * 
interval_of_broker_registration, where alpha is somewhat 1.5 or 2?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to