[GitHub] [rocketmq] mxsm commented on a diff in pull request #5325: [ISSUE #5324]Replace deprecated class PosixParser with DefaultParser for CLI

Sun, 16 Oct 2022 19:42:44 -0700 


mxsm commented on code in PR #5325:
URL: https://github.com/apache/rocketmq/pull/5325#discussion_r996567862


##########
tools/src/test/java/org/apache/rocketmq/tools/command/acl/UpdateAccessConfigSubCommandTest.java:
##########
@@ -49,7 +49,7 @@ public void testExecute() {
         // Note: Posix parser is capable of handling values that contains '='.
         final CommandLine commandLine =
             ServerUtil.parseCmdLine("mqadmin " + cmd.commandName(), subargs,
-                cmd.buildCommandlineOptions(options), new PosixParser());
+                cmd.buildCommandlineOptions(options), new DefaultParser());

Review Comment:
   @lizhanhui DefaultParser can handle values that contain '=', The following 
validation:
   **case1:**
   
![image](https://user-images.githubusercontent.com/15797831/196077246-5026435e-2700-4960-acc3-76734bc18778.png)
   debug result:
   
![image](https://user-images.githubusercontent.com/15797831/196077419-bd9dab1e-d13f-462f-8624-0d66390deed9.png)
   **case 2:**
   
![image](https://user-images.githubusercontent.com/15797831/196077583-0eb69ad5-ce7a-4d83-a86c-5d61de93e059.png)
   debug result:
   
![image](https://user-images.githubusercontent.com/15797831/196077532-18d80f54-5901-48de-aa4f-281a52ca7093.png)
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to