GitHub user dongeforever opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/18
[ROCKETMQ-20] Default 'consumeFromWhere' is inconsist with example's
The example pull consumer has a line code like this:
consumer.setConsumeFromWhere(ConsumeFromWhere.CONSUME_FROM_FIRST_OFFSET)
This is not necessary for a minimum viable pull consumer.
If this line is important, then it should be the default value.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dongeforever/incubator-rocketmq ROCKETMQ-20
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/18.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18
----
commit c7f4da7cdb1f55e663b5ab284fb40b53c3ce651a
Author: dongeforever <zhendongli...@yeah.net>
Date: 2016-12-27T16:19:05Z
ROCKETMQ-20 default 'consumeFromWhere' is inconsist with example's
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
