Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94103642
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/filtersrv/FilterServerUtil.java
---
@@ -26,9 +26,9 @@ public static void callShell(final String shellString,
final Logger log) {
String[] cmdArray = splitShellString(shellString);
process = Runtime.getRuntime().exec(cmdArray);
process.waitFor();
- log.info("callShell: <{}> OK", shellString);
+ log.info("CallShell: <{}> OK", shellString);
} catch (Throwable e) {
- log.error("callShell: readLine IOException, " + shellString,
e);
+ log.error("CallShell: readLine IOException, {}", shellString,
e);
--- End diff --
Wrong usage for log.error, please review it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
