Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq-site/pull/3#discussion_r94729784
--- Diff: _docs/06-best-practice-pull-request.md ---
@@ -4,23 +4,40 @@ permalink: /docs/pull-request/
modified: 2016-12-24T15:01:43-04:00
---
-There are several ways to setup Git for committers and contributors.
Contributors can safely setup Git any way they choose but committers should
take extra care since they can push new commits to the master at Apache and
various policies there make backing out mistakes problematic. Therefore all but
very small changes should go through a PR, even for committers. To keep the
commit history clean take note of the use of --squash below when merging into
apache/master.
+There are several ways to setup Git for committers and contributors.<br />
+Contributors can safely setup Git any way they choose but committers
should take extra care since they can push new commits to the master at Apache
and various policies there make backing out mistakes problematic. Therefore all
but very small changes should go through a PR, even for committers.<br />
+To keep the commit history clean take note of the use of `--squash` when
merging into apache/master.
--- End diff --
yes, right, I haven't noticed it in the original version. I will modify it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
