Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/30
@vintagewang `super.connect` can throw NPE when remoteAddress is null,
but as far as I see in netty code, it is ok (notification is raised). And the
client handles this in `invoke*` methods by `throw new
RemotingConnectException(addr);` (for instance, NettyRemotingClient lines
518-519).
To summarize, it looks safe.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
