Hi, +1 binding
The source release has a few minor issue that can be fixed next time. The binary release does need some work in it’s LICENSE and NOTICE. I checked: - incubating in file names - hashes and signatures good - DISCLAIMER exists - LICENSE and NOTICE good - All source files have ASF headers - No unexpected binary files - Can compile from source Nice work! This file [1] is still in the release and was brought up as an issue for last release candidate. Do we want to release with this error file in the source? Even if the votes passes up to the release manager to consider. The README still has some issues I think, but lets fix them up after this release. We want to make sure that the first point of contact for developers and users are these mailing lists / incubating site and there no prominent 3rd party links in there. Some very minor things to consider changing: - BUIDLING refers to tar.gz packages but the source package is a zip - CONTRIBUTING section “Becoming a committer” and "important contribution points” needs a little work IMO - The pom lists a number of developers and GitHub links, this is unusual for an Apache project. The binary the LICENSE and NOTICE will need some more work as it bundles a number of things that are not from the ASF, having multiple license or are Apache licensed. See [2] (notice that affects ours), [3] (not ASF apache software), [4] (multiple licenses), [5] (multiple licenses), [6] (non Apache license), [7] (non Apache license), [8] (notice file)., [9] (non Apache license). Thanks, Justin 1. rocketmq-all-4.0.0-incubating/store/hs_err_pid87490.log 2. https://github.com/apache/commons-lang/blob/master/NOTICE.txt 3. https://github.com/alibaba/fastjson 4. https://github.com/jboss-javassist/javassist/blob/master/License.html 5. https://github.com/java-native-access/jna 6. https://mvnrepository.com/artifact/ch.qos.logback/logback-classic 7. https://mvnrepository.com/artifact/ch.qos.logback/logback-core 8. https://github.com/netty/netty/blob/4.1/NOTICE.txt 9. https://www.slf4j.org/license.html
