[GitHub] incubator-rocketmq pull request #152: [ROCKETMQ-278] Add clusterlist cmd by ...

[vongosling]

Github user vongosling commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/152#discussion_r139871898
  
    --- Diff: 
tools/src/main/java/org/apache/rocketmq/tools/command/topic/TopicListSubCommand.java
 ---
    @@ -65,7 +65,7 @@ public void execute(final CommandLine commandLine, final 
Options options,
             try {
                 defaultMQAdminExt.start();
                 if (commandLine.hasOption('c')) {
    -                ClusterInfo clusterInfo = 
defaultMQAdminExt.examineBrokerClusterInfo();
    +                ClusterInfo clusterInfo = 
defaultMQAdminExt.examineBrokerClusterInfo(null);
    --- End diff --
    
    null as parameter is not a good practice


---