GitHub user lindzh opened a pull request:

    https://github.com/apache/incubator-rocketmq/pull/168

    Fix System.out.printf throws UnknownFormatConversionException

    ###  What is the purpose of the change 
    When using mqadmin command printmsg to print retry topic msgs,it throw an 
exception like this:
    com.alibaba.rocketmq.client.exception.MQClientException: Can not find 
Message Queue for this 
    ```
    topic, %%RETRY%%CID_MERSS_CONSUOUP_UAT
    See http://rocketmq.apache.org/docs/faq/ for further details.
      at 
com.alibaba.rocketmq.client.impl.MQAdminImpl.fetchSubscribeMessageQueues(MQAdminImpl.java:161)
      at 
com.alibaba.rocketmq.client.impl.consumer.DefaultMQPullConsumerImpl.fetchSubscribeMessageQueues(DefaultMQPullConsumerImpl.java:136)
      at 
com.alibaba.rocketmq.client.consumer.DefaultMQPullConsumer.fetchSubscribeMessageQueues(DefaultMQPullConsumer.java:225)
      at 
com.alibaba.rocketmq.tools.command.message.PrintMessageSubCommand.execute(PrintMessageSubCommand.java:120)
      at 
com.alibaba.rocketmq.tools.command.MQAdminStartup.main0(MQAdminStartup.java:128)
    ,. JIRA: https://issues.apache.org/jira/browse/ROCKETMQ-278.
    ```
    ### Brief change log
    * fix all system.out.prinf using in rocketmq.
    
    ### Verifying this change
    * This change is a trivial rework / code cleanup with unitout test coverage.
    * execute mqadmin printmsg -t %RETRY%CID_MERSS_CONSUOUP_UAT.
    
    Follow this checklist to help us incorporate your contribution quickly and 
easily:
    - [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/projects/ROCKETMQ/issues/)  filed for the 
change (usually before you start working on it). Trivial changes like typos do 
not require a JIRA issue. Your pull request should address just this issue, 
without pulling in other changes - one PR resolves one issue. 
    - [x]  Format the pull request title like [ROCKETMQ-XXX] Fix 
UnknownException when host config not exist. Each commit in the pull request 
should have a meaningful subject line and body.
    - [x]  Write a pull request description that is detailed enough to 
understand the pull request :
      - What is the purpose of the change
      - Brief change log
      - Verifying this change
    - [x] Write necessary unit-test to verify your logic correction, more mock 
a little better when cross module dependency exist. If the new feature or 
significant change is committed, please remember to add integration-test in 
[test module](https://github.com/apache/incubator-rocketmq/tree/master/test).
    - [x]  Run mvn -B clean apache-rat:check findbugs:findbugs 
checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install 
-DskipITs to make sure unit-test pass. Run mvn clean test-compile 
failsafe:integration-test to make sure integration-test pass. 
    - [x]  If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lindzh/incubator-rocketmq fix_print

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-rocketmq/pull/168.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #168
    
----
commit 1ae0693693da4a147f1bb3c122833f548c376b09
Author: lindzh <linso...@163.com>
Date:   2017-08-11T07:55:24Z

    Merge branch 'develop' of github.com:apache/incubator-rocketmq into develop

commit f0e243c5a8899fedc157accef964a1d617d77d1b
Author: lindzh <linso...@163.com>
Date:   2017-08-11T10:02:36Z

    Merge branch 'develop' of github.com:apache/incubator-rocketmq into develop

commit 1810be4c560767b83ff173e6fb6a96d4ac7c1428
Author: lindzh <linso...@163.com>
Date:   2017-08-14T02:11:27Z

    Merge branch 'develop' of github.com:apache/incubator-rocketmq into develop

commit 53dcd8d0837eee419810f055a4035d3fdd72513f
Author: lindzh <linso...@163.com>
Date:   2017-08-22T12:34:49Z

    Merge branch 'develop' of github.com:apache/incubator-rocketmq into develop

commit 4abfa4f326d0f5ac7a01f43b3cb882a7916fac59
Author: lindzh <linso...@163.com>
Date:   2017-08-28T10:41:53Z

    Merge branch 'develop' of github.com:apache/incubator-rocketmq into develop

commit 845830865fc37d0364a19cbd89ceaf8a30b37e1c
Author: yukon <yu...@apache.org>
Date:   2017-08-29T16:06:13Z

    Polish merge script, use old title if input is null

commit 254d432496c424717d45b8dc9e44ae3bd78ab466
Author: vsair <liuxue...@gmail.com>
Date:   2017-08-29T16:14:27Z

    [ROCKETMQ-284] ExpressionMessageFilter will pass some message.
    
    Author: vsair <liuxue...@gmail.com>
    
    Closes #160 from vsair/ROCKETMQ-284.

commit d576e38db79e4437dc2b304a6d6ef3a0e9337f74
Author: lindzh <linso...@163.com>
Date:   2017-08-30T06:38:39Z

    Merge branch 'develop' of github.com:apache/incubator-rocketmq into develop

commit 6a97d2884fe8ea23de8f231c8647b99ea5be1811
Author: 傅冲 <yubao....@alibaba-inc.com>
Date:   2017-09-05T03:30:11Z

    [ROCKETMQ-281] Add check policy for preventing repeat start mq
    
    Author: 傅冲 <yubao....@alibaba-inc.com>
    Author: fuyou001 <fuyou...@gmail.com>
    
    Closes #158 from fuyou001/ROCKETMQ-281.

commit 368e7c86a0b06099f336c81672112dcb5143cf9e
Author: 傅冲 <yubao....@alibaba-inc.com>
Date:   2017-09-05T12:28:23Z

    [ROCKETMQ-265] fix consume queue's data maybe repeat bug
    
    Author: 傅冲 <yubao....@alibaba-inc.com>
    Author: fuyou001 <fuyou...@gmail.com>
    
    Closes #146 from fuyou001/ROCKETMQ-265.

commit 27a678de3c592f4b87c4284bba64b2d50d966785
Author: wangkai <8738...@qq.com>
Date:   2017-09-20T04:19:15Z

    [ROCKETMQ-273] return an expression when a function has no write operations.
    
    Author: wangkai <8738...@qq.com>
    
    Closes #150 from kevin-better/develop.

commit bb446c48fa54cb542708f1ee171d49b1f6d1cd64
Author: lindzh <linso...@163.com>
Date:   2017-09-21T07:15:43Z

    Merge branch 'develop' of github.com:apache/incubator-rocketmq into develop

commit 144c270a84da144647b80c05df6cc287370e2963
Author: lindzh <linso...@163.com>
Date:   2017-09-21T07:36:36Z

    fix system.out.printf

----


---

Reply via email to