Anil Gangolli wrote:

+0.

I'm not sure that it will really address the ROL-1136 issue if people will still be stuck with logging in with the username they originally picked.

True, it doesn't technically solve the problem of being able to modify usernames if that is what is needed, but having the ability to modify usernames is a semi-sensitive subject.



It will also mean that we will need to look through the templates for places where we should be using screenName instead of either userName or fullName.

That is included in the patch. That patch just changes all themes to use screenName which I think is the best approach, but we could just change the userName uses to screenName if we wanted.



I can see that it might be a useful attribute to support though.

I agree, having a field that is meant to be the users "blogger name" makes a lot of sense and more than anything I think its better that we have the screenName field so that we can stop displaying userName, which isn't appropriate in many cases.

-- Allen



--a.


----- Original Message ----- From: "Matt Raible" <[EMAIL PROTECTED]>
To: <[email protected]>
Sent: Friday, April 27, 2007 10:33 AM
Subject: Re: Patch for ROL-1136


+1 to adding this feature.

On 4/27/07, Allen Gilliland <[EMAIL PROTECTED]> wrote:
I've reviewed this patch and tested it out and everything looks good to
me, so I am +1 to committing this work.

I am in favor of adding a screen name attribute to the User profile so
that we can have a field separate from user name which users can use to
indicate their public name any way they choose.  This way username can
remain a fixed field and more importantly it gets protected from public
visibility which is a security concern in certain environments.

If anyone else has an alternate opinion please speak up, if I don't hear
anything I plan to commit this next week.

-- Allen


Matthew Montgomery wrote:
> Allen Gilliland wrote:
>> can you attach the patch to the Jira issue?
>
> Done.
>
>>
>> -- Allen
>>
>>
>> Matthew Montgomery wrote:
>>> I took a stab at adding support for a screen name parameter which is
>>> one way to address ROL-1136.
>>>
>>> http://opensource.atlassian.com/projects/roller/browse/ROL-1136
>>>
>>> I have a patch that can be applied to the current trunk which touches
>>> some 25 files. It essentially adds a "screenName" parameter to the
>>> user profile and matches access occurrences with "fullName." I have
>>> also modified the included themes so that "screenName" is made
>>> visible in place of "username" and "fullName." I didn't attempt to
>>> add this change to source files located in the sandbox directory.
>>>
>>> I made the following DB alteration.
>>>
>>> alter table rolleruser add screenname varchar(255) not null;
>>>
>
>



--
http://raibledesigns.com


Reply via email to