On 5/19/07, Allen Gilliland <[EMAIL PROTECTED]> wrote:
One other thing that I forgot to mention before but while I am not a fan of is the separate init() method which was added. I can't really tell from the code why this is needed, my only guess being that you had to externalize the init() code from the constructor because the dependencies are injected after construction. If that's the case then that would be another reason why I favor injecting into the constructor rather than public setter methods, because then the init() code can take place in the constructor where it is 1) most appropriate and 2) guaranteed to happen before the object is returned for use.
The init() method was added because of the IndexManagerImpl, which calls Roller in it's constructor -- that's the circular dependency I mentioned. I'd prefer to see initialization take place in the constructor for all managers, if possible. Hmm... that reminds me. I wonder what happened to Elias' new search implementation. - Dave
