k ... this work is complete now so don't be scared when you update your
trunk workspace and you see so many scrolling lines you think you are in
the Matrix ;)
there are a few things which i left unaltered because I wasn't sure what
we want to do with them, such as ...
build.sh & build.bat - I suggest we just ditch them. Most people know
how to use ant fine on their own and so many people are using IDEs these
days that it's unlikely these are being of much use.
contrib/ - this is a pretty defunct directory which only contains a
couple of really old (and unsupported) plugins. again, i vote to just
ditch it.
metadata/xdoclet/ - i don't think we need this any more, but i figured
i'd wait a bit and see.
metadata/database/ - we still need this because it's used by both
Weblogger and Planet for the db script generation, but maybe we can
move/rename it since it's in a somewhat obscure location right now.
-- Allen
Allen Gilliland wrote:
k ... I plan to do this in batches and I have the first batch of this
work queued up in my workspace so I am planning to go ahead and commit
it pretty soon.
-- Allen
Allen Gilliland wrote:
Sure. Since it sounds like people are in favor of this I'll begin
working on it today and I should be able to start committing the
changes this afternoon.
-- Allen
Dave wrote:
Please send out a heads-up before you start work on this.
All my workspaces are checked-in now and ready for a refactoring.
I'll probably drop the roller_guice branch and re-create it when you
are done.
- Dave
On 5/29/07, Allen Gilliland <[EMAIL PROTECTED]> wrote:
Since 4.0 is a major release I'd like to suggest some cleanup and
refactoring work which has no real bearing on functionality but I think
provides some nice cleanup to the project and makes the code easier to
understand and read. These don't have to be taken all together, so
feel
free to comment on them independently ...
1. Move Roller Weblogger code to new project space in apps/weblogger/*
structured the same way as the Roller Planet project. This provides
better consistency in the build environment.
2. Update Roller Weblogger java packaging from apache.roller.* to
apache.roller.weblogger.*. It always kind of sucks to do major package
renames like this, but I think this is a good thing and this should be
the last time we have to do this for quite a while.
3. Drop "Data" from the end of our pojo names. I still think that this
convention is a waste and just muddies up our pojo names. At one point
I think this convention was meant to identify which pojos were
persistent, but I see no point in doing that because ultimately
persistence is supposed to be transparent. Also, pretty much all our
pojos are persistent anyways so all we've really done is made our pojo
names longer for no reason.
4. Rename some pojos for consistency. One general theme here is to
append "Weblog" in front of those objects which are directly
attached to
a weblog to make that relationship clear ...
WebsiteData -> Weblog
PermissionsData -> WeblogPermission
FolderData -> WeblogBookmarkFolder
BookmarkData -> WeblogBookmark
HitCountData -> WeblogHitCount
RefererData -> WeblogReferrer
CommentData -> WeblogEntryComment
EntryAttributeData -> WeblogEntryAttribute
RoleData -> UserRole
I think that's enough for now. Please weigh in with your thoughts on
these, I'd like to start applying them soonish if we are agreed.
-- Allen
