Hello Dave,... My fault,.. I was planning to fix the problem,....
I suggest the following solution:
in Weblog.vm put
#if($model.weblog.stylesheet)
<link rel="stylesheet" type="text/css" href='$model.weblog.stylesheet' />
#else
<link rel="stylesheet" type="text/css"
href='$url.resource("styles/default.css")' />
#end
<style type="text/css">#includeTemplate($model.weblog "_css")</style>
And still keep CSS in theme.xml like this:
<!-- stylesheet -->
<stylesheet>
<name>custom.css</name>
<description>Stylesheet</description>
<link>custom.css</link>
<templateLanguage>velocity</templateLanguage>
<contentsFile>styles/default.css</contentsFile>
</stylesheet>
And don't put the CSS file as a resource.
In this case such themes will be back compatible with 3.x and work in 4.0 with
possibility to customize CSS.
What do you think?
Gene
----- Original Message ----
From: Dave <[EMAIL PROTECTED]>
To: [email protected]
Cc: "[EMAIL PROTECTED]" <[EMAIL PROTECTED]>
Sent: Monday, September 17, 2007 10:45:12 AM
Subject: Fixes to Roller themes for 4.0
I made a series of fixes to the Roller themes in the Roller Support
project (http://roller.dev.java.net), including those from
rollerthemes.com.
There were missing resources in the themes files and a couple of other
problems. The themes all seem to be working pretty well now, but there
is one issue.
All of the rollerthemes.com themes have a <stylesheet> specified in
theme.xml, which means they all support stylesheet override. However,
none of theme include the stylesheet over-ride as they should. This
should appear in the <head> of each Weblog template:
<link rel="stylesheet" type="text/css" href="$model.weblog.stylesheet"/>
And because the stylesheet is handled that way, there is no need for
lines like this in theme.xml, which copies the stylesheet into the
resource area.
<resource path="styles/default.css" />
Everybody (and Eugene) OK with me making the above changes to the
themes at the Roller Support project?
- Dave
