Hi Dave, On Fri, Jul 8, 2011 at 8:55 AM, Dave <[email protected]> wrote:
> Hi Shelan, > > Here's some feedback on the design for the new theme chooser page in > Roller, the one that allows you to pick a standard and a mobile theme. > > This feedback is based on your blog post and the screenshot here: > > http://rollermobile.blogspot.com/2011/07/changing-mobile-theme-template.html > > I don't see how the design works. When you pick Shared or Custom > theme, which type of theme does the choice apply to? > At the moment i have implemented the mobile theme updating for shared themes only. So if you select custom theme, It will show only custom standard themes.Actually i was about to discuss the custom theme mobile implementation since it has a significant impact on the rendering in the core. (When you have a custom theme in the system ,retrieving stylesheets ,templates etc has some specific logic that has to be handled with care and with some proper knowledge on the flow.) So when you select shared theme box it will have mobile and standard templates.(Both of them show on the same page.) It is a cloned drop down and preview of standard theme which loads mobile templates. (in the screen shot right hand side drop down shows that. and below that preview link will show mobile preview. when you press update mobile theme button below that it will update weblog's mobile theme.) > > It should be possible to pick either a Shared or Custom standard > theme, and a Shared or Custom mobile theme. I think a better design > would be to use two separate pages, one for the standard theme (as we > have now) and one for the mobile theme. Both pages would look similar > and would have two boxes at the top for choosing standard or mobile, a > chooser for selecting a theme and an Update Theme button. > > I implemented both mobile and standard theme update on same page as an outcome decision of a meeting.I may have got it wrong. :). It would be easier to manage the logic with a separate page for mobile shared and custom theme selection.I think it would be a sub tab under design tab to select "mobile theme" [ we have theme,stylesheet,templates at the moment] > For the stylesheet page, I think we can still use one page. You could > use a design similar to the new Edit Template page, with one tab for > the Standard part of the template and one for the Mobile part. > > This would be ideal to have.I will add this. > Does that make sense or am I missing something? > Thank you very much for the feedback. > > Thanks, > Dave > -- Shelan Perera Home: http://www.shelan.org Blog : http://www.shelanlk.com Twitter: shelan skype :shelan.perera gtalk :shelanrc I am the master of my fate: I am the captain of my soul. *invictus*
