Yep, a space works for me.

On Apr 7, 2013, at 15:26, Greg Huber <[email protected]> wrote:

> Matt,
> 
> Rechecking this, the std code
> 
> <a href="$link"
> class="commentslink">$text.get("macro.weblog.comments")[$commentCount]</a>
> 
> renders:
> 
> $text.get("macro.weblog.comments")[$commentCount]
> 
> I think it needs a space (between the two) or a formal notation:
> 
> <a href="$link" class="commentslink">$text.get("macro.weblog.comments")
> [$commentCount]</a>
> <a href="$link"
> class="commentslink">${text.get("macro.weblog.comments")}[$commentCount]</a>
> 
> renders:
> 
> Comments [0]
> Comments[0]
> 
> Think you probably wanted a space?  Will update it with a space instead.
> 
> Cheers Greg
> 
> 
> 
> 
> On 7 April 2013 20:26, Matt Raible <[email protected]> wrote:
> 
>> The are two different calls I believe.
>> 
>> $text.get(key) gets a message. Whereas $text.get(key, arg) substitutes a
>> variable in. So I believe it depends on the message being retrieved.
>> 
>> On Apr 7, 2013, at 11:21 AM, Greg Huber <[email protected]> wrote:
>> 
>>> Matt,
>>> 
>>> before:
>>> 
>>> <a href="$link"
>> class="commentslink">$text.get("macro.weblog.comments")[$commentCount]</a>
>>> 
>>> after
>>> 
>>> <a href="$link"
>> class="commentslink">$text.get("macro.weblog.comments"),[$commentCount])</a>
>>> 
>>> When I was testing, initially I thought it only needed a closing bracket,
>>> which I added, but it still did not render.  I then added the comma which
>>> fixed it.  I will recheck, but I think it needs the comma between the
>>> variabes.
>>> 
>>> Cheers Greg.
>>> 
>>> 
>>> On 7 April 2013 17:29, Matt Raible <[email protected]> wrote:
>>> 
>>>> I don't understand - how does adding a comma help the comment count
>>>> display?
>>>> 
>>>> On Apr 7, 2013, at 2:10 AM, [email protected] wrote:
>>>> 
>>>>> Author: ghuber
>>>>> Date: Sun Apr  7 08:10:44 2013
>>>>> New Revision: 1465342
>>>>> 
>>>>> URL: http://svn.apache.org/r1465342
>>>>> Log:
>>>>> Comment count not showing
>>>>> 
>>>>> Modified:
>>>>>  roller/trunk/weblogger-webapp/src/main/webapp/themes/basic/_day.vm
>> roller/trunk/weblogger-webapp/src/main/webapp/themes/brushedmetal/_day.vm
>>>>>  roller/trunk/weblogger-webapp/src/main/webapp/themes/fauxcoly/day.vm
>>>>> 
>>>>> Modified:
>>>> roller/trunk/weblogger-webapp/src/main/webapp/themes/basic/_day.vm
>>>>> URL:
>> http://svn.apache.org/viewvc/roller/trunk/weblogger-webapp/src/main/webapp/themes/basic/_day.vm?rev=1465342&r1=1465341&r2=1465342&view=diff
>> ==============================================================================
>>>>> --- roller/trunk/weblogger-webapp/src/main/webapp/themes/basic/_day.vm
>>>> (original)
>>>>> +++ roller/trunk/weblogger-webapp/src/main/webapp/themes/basic/_day.vm
>>>> Sun Apr  7 08:10:44 2013
>>>>> @@ -24,7 +24,7 @@
>>>>>           #set($commentCount = $entry.commentCount)
>>>>>           #if($entry.commentsStillAllowed || $commentCount > 0)
>>>>>               #set($link = "$url.comments($entry.anchor)" )
>>>>> -                <a href="$link"
>> class="commentsLink">$text.get("macro.weblog.comments")[$commentCount]</a>
>>>>> +                <a href="$link"
>> class="commentsLink">$text.get("macro.weblog.comments"),[$commentCount])</a>
>>>>>           #end
>>>>>       </p>
>>>>>       #showTrackbackAutodiscovery($entry)
>>>>> 
>>>>> Modified:
>> roller/trunk/weblogger-webapp/src/main/webapp/themes/brushedmetal/_day.vm
>>>>> URL:
>> http://svn.apache.org/viewvc/roller/trunk/weblogger-webapp/src/main/webapp/themes/brushedmetal/_day.vm?rev=1465342&r1=1465341&r2=1465342&view=diff
>> ==============================================================================
>>>>> ---
>> roller/trunk/weblogger-webapp/src/main/webapp/themes/brushedmetal/_day.vm
>>>> (original)
>>>>> +++
>> roller/trunk/weblogger-webapp/src/main/webapp/themes/brushedmetal/_day.vm
>>>> Sun Apr  7 08:10:44 2013
>>>>> @@ -24,7 +24,7 @@
>>>>>           #end
>>>>>           #set($commentCount = $entry.commentCount)
>>>>>           #if($entry.commentsStillAllowed || $commentCount > 0)
>>>>> -                <a href="$url.comments($entry.anchor)"
>> class="commentsLink">$text.get("macro.weblog.comments")[$commentCount]</a>
>>>>> +                <a href="$url.comments($entry.anchor)"
>> class="commentsLink">$text.get("macro.weblog.comments"),[$commentCount])</a>
>>>>>           #end
>>>>>       </p>
>>>>>       #showTrackbackAutodiscovery($entry)
>>>>> 
>>>>> Modified:
>>>> roller/trunk/weblogger-webapp/src/main/webapp/themes/fauxcoly/day.vm
>>>>> URL:
>> http://svn.apache.org/viewvc/roller/trunk/weblogger-webapp/src/main/webapp/themes/fauxcoly/day.vm?rev=1465342&r1=1465341&r2=1465342&view=diff
>> ==============================================================================
>>>>> ---
>> roller/trunk/weblogger-webapp/src/main/webapp/themes/fauxcoly/day.vm
>>>> (original)
>>>>> +++
>> roller/trunk/weblogger-webapp/src/main/webapp/themes/fauxcoly/day.vm
>>>> Sun Apr  7 08:10:44 2013
>>>>> @@ -30,7 +30,7 @@
>>>>>           #set($commentCount = $entry.commentCount)
>>>>>           #if($entry.commentsStillAllowed || $commentCount > 0)
>>>>>               #set($link = "$url.comments($entry.anchor)" )
>>>>> -                <a href="$link"
>> class="commentslink">$text.get("macro.weblog.comments")[$commentCount]</a>
>>>>> +                <a href="$link"
>> class="commentslink">$text.get("macro.weblog.comments"),[$commentCount])</a>
>>>>>           #end
>>>>> 
>>>>>           #if ($utils.isUserAuthorizedToAuthor($entry.website))
>> 
>> 

Reply via email to