Big +1 on that. Those annotations are definitely confusing to people who
are new to the code.

- Dave



On Sun, Nov 24, 2013 at 6:06 PM, Glen Mazza <[email protected]> wrote:

> Hi team, IntelliJ IDEA is noting many annotations in our Roller trunk code
> comments that don't seem to be doing anything:
>
> 144 @hibernate annotations (we use JPA and EclipseLink by default today)
> 117 @ejb annotations (all seem to be ejb:persistent-field, and we're not
> using ejb's for Java App Server deployment)
> 129 @roller annotations (all seem to be roller.wrapPojoMethod)
> 14 @struts annotations (.validator, .validator-args, .validator-var, .form)
>
> The ones I'm unsure about are the @roller and @struts annotations --
> anybody know if these still have meaning?
>
> An example of a class having all four is WeblogEntry:
> http://svn.apache.org/viewvc/roller/trunk/app/src/main/
> java/org/apache/roller/weblogger/pojos/WeblogEntry.java?view=markup
>
> WeblogBookmark has several @struts annotations:
> http://svn.apache.org/viewvc/roller/trunk/app/src/main/
> java/org/apache/roller/weblogger/pojos/WeblogBookmark.java?view=markup
>
> OK if I remove the above annotations?
>
> Thanks,
> Glen
>
>

Reply via email to