On Tue, Jul 22, 2014 at 9:04 AM, Glen Mazza <[email protected]> wrote:
> On 07/22/2014 08:25 AM, Dave wrote: > >> -1 >> >> Old path support is built into Roller so that the huge number of resources >> that were uploaded before this change would not go 404. We definitely do >> not want to remove that. >> > > No, I was only suggesting turning off the ability to rename the original > path, not to get rid of it. I thought from its name "original path" that > this was intended only as a temporary critter as part of migration from > Roller 4 to Roller 5, something that would eventually go away. > > If it is your intention to permanently retain this functionality, can we > rename it on the GUI as something like "Friendly URL (optional)" That is > clearer than "original path", as it doesn't imply the past but just > current, helpful functionality. I can see Friendly URL as a nice feature, > so bloggers reading their HTML have a better idea of what the image is > pointing to. Yes, it should be permanent. If a resource has an "original path" then it needs to be respected, otherwise links to all resources uploaded before Roller 5 will be 404s. Friendly URL Is definitely a nice feature idea too. > The ability to edit the original path is a very useful feature that allows >> you to set a URL for a resource and avoid using the ugly one that Roller >> generates. Rather than remove it, I would rather see default to "true." >> It's trivial to support and if you don't like it, you can turn it off. >> > > OK, but we'd have to make sure validation is in place before we default it > to true, and some of that validation may not be trivial. We have to guard > against multiple bloggers typing in the same original path, as well as a > blogger typing in the same original path for multiple images, as well as a > blogger reusing someone else's ugly URL to replace the picture on someone > else's blog (i.e., you blog an article with an ugly URL pointing to some > picture, I add an image with a "friendly URL" identical to your ugly URL -- > will your blog still continue to show your picture--as it should--and not > mine?) Ideally, it should be impossible for a friendly URL to ever equal > an ugly one -- because it uses a different URL structure perhaps. Yes, definitely. More work is needed before this original path feature is made a public part of the UX -- and users must be made aware that changing original path or "friendly URL" will break any links that were made to the resource before the change. - Dave > >> - Dave >> >> >> >> On Mon, Jul 21, 2014 at 11:38 PM, Glen Mazza <[email protected]> >> wrote: >> >> Hi team, a property in our roller.properties I think we can get rid of >>> now: >>> >>> # Allow users to edit the original path setting of media files >>> mediafile.originalPathEdit.enabled=false >>> >>> Its only use is in MediaFileEdit.jsp: >>> >>> <!-- original path from base URL of ctx/resources/ --> >>> <s:if test="getBooleanProp('mediafile.originalPathEdit. >>> enabled')"> >>> <tr> >>> <td class="originalPathLabel"> >>> <label for="originalPath"><s:text name="mediaFileEdit. >>> originalPath" >>> /></label> >>> </td> >>> <td> >>> <div id="fileControldiv" class="miscControl"> >>> <s:textfield name="bean.originalPath" size="30" >>> maxlength="100" tabindex="3" /> >>> <br /> >>> </div> >>> </td> >>> </tr> >>> </s:if> >>> >>> This was related to the switch from simple file uploads to the new Media >>> File functionality which occurred from 4.0 to 5.0. An "original path" >>> URL >>> was retained to allow the older-type URLs to remain within blog entries, >>> instead of requiring them to switch to the new cryptic URLs used by >>> Roller. >>> Roller will still read the old URLs to identify an image if necessary, >>> but >>> I think by this stage, we don't need to allow people to change the old >>> URLs >>> -- let them switch to the new URLs used by Roller if they have a problem >>> viewing any image? >>> >>> Thanks, >>> Glen >>> >>> >
