I just pushed a fix that skips these tests on Java 1.7. Dave
On Sun, Jun 9, 2019 at 4:22 AM sebb <seb...@gmail.com> wrote: > On Sat, 8 Jun 2019 at 19:12, Dave <snoopd...@gmail.com> wrote: > > > > Thanks for the report Sebb. > > > > It appears that the problem is that the test is attempting to fetch an > RSS > > feed from a website that uses TLS 1.2 and older versions of Java 1.7 do > not > > support TLS 1.2. That's why this error appears in roller.log: > > > > javax.net.ssl.SSLException: Received fatal alert: protocol_version > > > > TLS support was added to Java 1.7 in build 131, but have to buy a license > > from Oracle to get that version. > > > > There are a couple of possible ways to fix this: > > > > 1 - Change the roller-5.2.x branch to target Java 1.8 instead > > 2 - Make the RSS feed tests as ignored > > 3 - Change the RSS feed test to pull from a TLS 1.1 site instead (can > we > > even find such a thing?) > > > > Thoughts? > > Given that this only affects a test case, and not the functioning of > Roller, seems to me that there is no need to update to Java 1.8. > Also if people want to test the code they can use Java 1.8. > > I would fix the test cases so they don't fail: instead print a message > to say they are skipped on Java 1.7 > Even if you can find a TLS 1.1 site, it may well be updated. > > Also update the release notes to say why those tests fail on Java 1.7 > > Obviously those work-rounds can be dropped when upgrading Java. > > > Thanks, > > Dave > > > > > > > > On Sat, Jun 8, 2019 at 12:39 PM sebb <seb...@gmail.com> wrote: > > > > > mvn clean install fails with: > > > > > > Tests in error: > > > RomeFeedFetcherTest.testFetchFeed:56 » Fetcher Error fetching > > > subscription - h... > > > RomeFeedFetcherTest.testFetchFeedConditionally:76 » Fetcher Error > > > fetching sub... > > > SingleThreadedFeedUpdaterTest.testUpdateSubscription:67 » Updater > > > Error fetchi... > > > > > > i.e. the test code compiles OK with Java 7, but the some tests fail. > > > > > > The tests work fine with Java8. > > > > > > Since the code currently targets 1.7, the tests ought to work as well. > > > >
