nuzayats opened a new pull request #75: URL: https://github.com/apache/roller/pull/75
Fixes some concurrency issues in the IPBanList class: * It calls HashSet#contains() from outside a synchronized block: it might not be able to catch a change made by a different thread * The bannedIps field is not volatile even though multiple threads can set it to a new instance from loadBannedIps(): other threads might not see the updated instance There are also some minor code improvements suggested by IntelliJ ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
