snoopdave opened a new pull request, #219:
URL: https://github.com/apache/roller/pull/219
Fixes found while running Roller 7 against a copy of the rollerweblogger.org
database.
## Reviewer's guide
Use `git diff -w`: wrapping two tables in `.table-responsive` re-indented
them.
1. **Pagination** — `Pager.jsp`, `MediaFilePager.jsp`,
`pagers/LinkPager.java`
- Entries, Comments and media search share one control: First / Newer /
Page N of M / Older / Last.
- New `getWeblogEntryCount`, `getCommentCount` and `getMediaFileCount`
use the same WHERE clause as their list queries, so a page and its count can't
disagree.
- `EntriesPager` and `CommentsPager` now extend `LinkPager`.
- Media search results past page 1 were unreachable. Search is a POST, so
its buttons resubmit the form with a page number.
- Fixes swapped Newer/Older labels on the bottom Entries pager.
- The comment bulk-delete count uses the new count instead of loading
every match.
2. **Entry editor** — `EntryEdit.jsp`, `EntryEditor.jsp`,
`TemplateEdit.jsp`: panels are Bootstrap 5 accordions, so they show a chevron.
The dead Bootstrap 3 chevron CSS is removed. Buttons sit in a spaced row.
3. **Layout** — Comment and entry tables no longer overflow narrow screens;
long unbroken spam URLs now wrap. Sidebar filter forms get spacing.
4. **Date fields** — `date-fields.js`: the calendar button is attached and
works (its `for=` pointed at a nonexistent id), filters get a clear button, and
the fields are no longer greyed out.
5. **Tests**
- `LinkPagerTest` and count assertions in the entry, comment and media
tests.
- `CommentTest` had no `@Test` annotations and never ran; now it does.
- `EntryEditorAssetsTest` still keeps the chevron off Summernote's menus,
rewritten for the accordion markup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
