snoopdave commented on PR #224:
URL: https://github.com/apache/roller/pull/224#issuecomment-6453919344

   **🤖 GLM: PR-Review — General Issues**
   
   The following issues were found but cannot be attached to a specific line in 
the diff:
   
   - **Important:** CHANGES.md has no entry for this change. Other PRs in the 
6.1.7 batch each carry one. Worth a note: signing in with an OpenID URL now 
refuses disabled accounts (previously a disabled user whose OpenID identity 
they still controlled could sign in).
   
   Strengths (not action items): placing the check before the OpenID-unknown 
fallback preserves the SREG auto-provisioning flow for genuinely unknown 
identities, and the new unit test covers both the enabled and disabled paths.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to