Hi Matt, Do you want to try out the new Apache Trusted Releases skill and spin up a Roller 7 RC once everything is merged today? I'm happy to do it, but maybe you want to drive this time?
Dave On Fri, Nov 13, 2026 at 6:43 PM Dave <[email protected]> wrote: > concur. I think we should have a one other approver rule as we are a small > project. > > > > On Fri, Nov 13, 2026 at 6:07 PM Matt Raible <[email protected]> > wrote: > >> I’m OK with it. It always seems strange to work on an OSS project and >> have the ability to merge right after creating a PR. >> >> I’ve done a lot of professional OSS and companies seem to always require >> a 2nd approver. >> >> That being said, we still don’t require it on JHipster, but we do have a >> convention that every PR gets an approval from a committer. >> >> > On Nov 13, 2026, at 15:33, Dave <[email protected]> wrote: >> > >> > On second thought, I do think approvals are more important now than they >> > were before because people are submitting AI generated PRs that they may >> > not 100% understand and these AI generated PRs are generally larger and >> > harder to review. >> > >> > Dave >> > >> > >> > On Fri, Nov 13, 2026 at 5:16 PM Dave <[email protected]> wrote: >> > >> >> It's awesome to see so many PRs open against Roller! Thanks, folks. I >> >> will do my best to review all things this weekend and drive towards a >> >> Roller 7 RC soon. >> >> >> >> Reviews are not required before merge based on our current policy. Does >> >> anybody think we should have branch protection and require 1 or 2 >> approvals >> >> on PRs? I am undecided about this. >> >> >> >> Dave >> >> >> >>
