mraible opened a new pull request, #256: URL: https://github.com/apache/roller/pull/256
Follow-up to Dave's review comment on #254, which I missed before merging it. `UtilitiesModel` remembers each invalid date pattern it has logged, so a busy page logs it once. Patterns come from templates, which weblog admins can edit, so the `ConcurrentHashMap`-backed set could grow without bound. - It's now a synchronized, access-ordered `LinkedHashMap` set that drops the least recently seen pattern past 100 entries. A pattern seen again stays at the front. - `UtilitiesModelFormatDateTest` formats a date with 150 distinct invalid patterns. It checks that each one still falls back to the default format and that the set never holds more than 100. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
