mraible opened a new pull request, #259:
URL: https://github.com/apache/roller/pull/259

   The WAR shipped two implementations of `org.apache.commons.logging`:
   - `commons-logging` 1.3.5, which Spring 7 depends on directly now that 
`spring-jcl` is gone.
   - `jcl-over-slf4j` 2.0.20.
   
   `jcl-over-slf4j` won (`LogFactory.getFactory()` returned `SLF4JLogFactory`), 
so every Roller log call went JCL → SLF4J → Log4j. Which jar wins also depends 
on classloader order, so it could differ between containers.
   
   commons-logging 1.3 and later detect the Log4j API and log to it directly, 
so:
   
   - `app` and `db-utils` declare `commons-logging` 1.4.0 (new 
`commons-logging.version` in the root pom; Java 8+, no known CVEs) and drop 
`jcl-over-slf4j`.
   - The `spring-jcl` exclusion on `spring-web` is removed. Spring 7 has no 
such module.
   - `app/src/main/webapp/META-INF/org.apache.commons.logging.LogFactory` is 
removed, with its license-check exclusion. It named `Log4jFactory`, which no 
longer exists, and a webapp's top-level `META-INF` isn't on the classpath, so 
it never applied.
   - SLF4J stays for libraries that log through it (`log4j-slf4j2-impl`, 
`jul-to-slf4j`).
   
   `CommonsLoggingRoutingTest` checks three things:
   - `LogFactory.getFactory()` is `Log4jApiLogFactory`.
   - `jcl-over-slf4j`'s factory class isn't on the classpath.
   - A message logged through commons-logging reaches a Log4j appender at the 
right level.
   
   The first two fail on master. `mvn install` passes (662 tests). On 
`jetty:run`, `roller.log` fills with Roller's own log lines as before.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to