mraible opened a new pull request, #262:
URL: https://github.com/apache/roller/pull/262
Moves the admin UI from jQuery 3.7.1 to 4.0.0.
- `app/pom.xml` and `head.jsp`: jQuery 4.0.0, and jQuery Validation 1.21.0 →
1.22.1. 1.21's peer range stops at jQuery 3, and 1.22.x is published only as an
`org.webjars.npm` webjar.
- `media-library.js`: the two `$.trim(...)` calls (removed in jQuery 4) now
use `String.prototype.trim`, which strips the same characters.
- I checked Roller's own scripts and the inline scripts in the JSPs against
the jQuery 4 upgrade guide. Covered: removed utilities, `toggleClass`, boolean
`.attr`, unitless `.css`, JSONP and script auto-execution, focus/blur order,
and `beforeunload`. Nothing else is affected.
Other libraries on the page:
- jQuery UI 1.14.2 (peer range `<5`), Bootstrap 5.3.8 and clipboard.js are
compatible.
- **Summernote 0.9.1**, the latest release and Roller's default editor,
still calls three APIs jQuery 4 removed:
- `jQuery.now()` when the editor starts, which would stop it from starting
at all;
- `jQuery.nodeName()` in list handling;
- `.push()` on a jQuery object in the table popover.
A search of Summernote's bundle found no others.
`roller-ui/scripts/jquery4-summernote-compat.js` restores just those three,
with their jQuery 3 behavior and only when they're missing, and `head.jsp`
loads it right before Summernote. It should go once a Summernote release
supports jQuery 4 (summernote/summernote#4822 is open).
`mvn test` passes. The browser behavior is what CI's UI tests check: they
publish entries through the Summernote editor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]