mraible opened a new pull request, #266:
URL: https://github.com/apache/roller/pull/266

   Follows the dev@ licensing thread (Dave: replace the Category B and 
unknown-origin assets). ASF policy allows Category B works such as OFL fonts 
and CC BY icons in binary form only, and some theme files had no recorded 
license at all.
   
   **Font Awesome 3.2.1 (OFL, Gaurav).** The five font files and 
`font-awesome.min.css` are removed. Gaurav used three icons: search, clock and 
chevron-right. They're now inline Bootstrap Icons SVGs (MIT, from the 
`bootstrap-icons` 1.13.2 webjar Roller already ships).
   
   They're inline, not separate files, for two reasons:
   - A customized theme copies its resources into the media library, which 
serves SVG as an attachment, so separate SVG files wouldn't render.
   - A versioned webjar path would go stale in customized copies.
   
   **Silk icons (CC BY 2.5).**
   - All 29 in `images/` are removed. The four in use are now Bootstrap Icons 
classes, which `head.jsp` already loads: `help.tag`, `Templates.jsp` and 
`UserEdit.jsp`.
   - The theme icons in `themes/{gaurav,fauxcoly}/icons/` (Silk, or from the 
2005 import with no recorded source) are now inline SVG or `data:` URI 
Bootstrap Icons in similar colours. That covers permalink, tag, comments, PDF, 
entry and feed icons, and the old social-bookmark logos. `asf-logo.png` stays.
   
   **`searchhi.js` (no license).** The three copies are gone. Each theme has a 
new `js/search-highlight.js`, written from scratch:
   - it reads the term from a `data-search-term` attribute;
   - it walks text nodes and wraps matches with `createElement` and 
`createTextNode`, so the term is never treated as markup;
   - it skips script and style content.
   
   Fauxcoly's old highlighter was served as a `text/html` template with 
`nosniff`, so it probably never ran.
   
   **Smileys.** `images/smileys/` (37 GIFs) is removed. The Emoticons plugin 
now emits Unicode emoji: `<span class="smiley" title=":-)">&#x1F642;</span>`. 
It also matches all emoticons in a single pass, longest first, so `:))` is no 
longer split and one replacement can't match inside another's markup. Titles 
are HTML-escaped.
   
   **Unused files removed:** `images/editor/*.gif` and the theme brand logos 
referenced only by `theme.xml`.
   
   Tests:
   - `ThemeAssetReferencesTest` checks four things:
     - every file a theme lists or loads exists;
     - every loaded file is listed in `theme.xml`;
     - relative `url()` targets in theme CSS exist;
     - every `/images/` and `/scripts/` path in JSP, tag, vm and css files 
exists.
   
     It fails if a template still points at a removed file.
   - `SmileysPluginTest` covers the new output.
   - `mvn test`: 669 passed. `apache-rat:check` passes.
   
   CHANGES.md notes that custom templates linking to the removed files will 
show broken images. Weblogs already on a customized copy keep their own files. 
#265 (LICENSE/NOTICE) will drop the Font Awesome and Silk entries and the 
famfamfam credit, and credit Bootstrap Icons for the inline SVG paths.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to