mraible opened a new pull request, #267:
URL: https://github.com/apache/roller/pull/267

   Found while testing 7.0 on a copy of raibledesigns.com.
   
   With `webservices.enableXmlRpc` off, every weblog with client support turned 
on still:
   - linked to its RSD document (`#showAutodiscoveryLinks`, `<link 
rel="EditURI">`);
   - served an RSD listing the Blogger and MetaWeblog endpoints, which then 
answered 404 "XML-RPC service is disabled".
   
   `XmlRpcEnabledFilter` also logged a WARN for every one of those refused 
calls.
   
   The fix:
   - `ConfigModel.getXmlRpcEnabled()` exposes the site setting to templates.
   - The macro links to the RSD only when `$weblog.enableBloggerApi && 
$config.xmlRpcEnabled`.
   - `RSDServlet` answers 404 unless both are on, since the RSD only describes 
that endpoint.
   - `XmlRpcEnabledFilter` logs refused requests at debug, as the AtomPub 
servlet does.
   
   `RSDServletTest` checks the servlet's condition for each combination of site 
and weblog setting, and renders the macro through Velocity. The template case 
fails on master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to