mraible commented on PR #263: URL: https://github.com/apache/roller/pull/263#issuecomment-6886897116
Both points from the review are addressed. **Request cap.** 7edbfb978 stops the cap at 32 MiB whatever `uploads.file.maxsize` is. It still rises with the upload size below that. A file over about 23 MB no longer fits through a blog client and has to go through the media library; CHANGES and the install guide say so, and there's a test for it. **Client interop.** I ran Python 3.15's `xmlrpc.client.ServerProxy` against a copy of raibledesigns.com (3,553 entries, MySQL 8.4, Tomcat 11), on this branch at f7cb27754 and on master at f3d120760 for comparison. No desktop client (MarsEdit, Open Live Writer) was tested. With the real client, on this branch: - `blogger.getUsersBlogs`, `metaWeblog.getCategories` and `metaWeblog.getRecentPosts` return what master returns. - `metaWeblog.newPost` with a draft whose title and body hold an emoji, accented letters and markup, then `getPost`: the title round-trips exactly, and the body differs only in line endings (the client sends a raw CRLF, which XML parsing turns into LF). - `metaWeblog.editPost` changes the title and category. `blogger.deletePost` removes the post. - `metaWeblog.newMediaObject` with a 70-byte PNG returns a URL that serves 70 bytes as `image/png`. Then the request shapes other clients send, as raw XML: - Accepted: untyped `<value>text</value>` strings, `<i4>`, whitespace around values, unknown `mt_*` and `wp_*` struct members, `publish` as `<int>0</int>`, a CDATA title, an emoji as one character reference, a body declared and encoded as ISO-8859-1, a UTF-8 byte order mark, and base64 on one line, folded at 76 with CRLF, or folded at 20 with LF and indentation. - Dates accepted: `20261114T12:00:00`, `2026-11-14T12:00:00`, `20261114T12:00:00Z`, `2026-11-14T12:00:00+05:30` (stored as 06:30 on a UTC server), `20261114T12:00:00.123Z` and `20261114T120000`. Master refuses the dashed, offset and no-colon forms. - Refused, as on master: `<i8>`, `<nil/>` and `<ex:nil/>`, a `<double>` or untyped string where an int is expected, a date without seconds (`20261114T12:00`), `<boolean>false</boolean>`, a missing `publish` parameter, and an emoji written as two surrogate character references. Two differences from master: - A `dateCreated` sent as an untyped string gets fault 1000 here and fault 0 on master. - On master, `getPost` and `getRecentPosts` return XML the client can't parse once a post contains an emoji, so the lifecycle above fails there at the first `getPost`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
