snoopdave opened a new pull request, #270: URL: https://github.com/apache/roller/pull/270
The Design menu (theme, stylesheet and templates) is shown only while `themes.customtheme.allowed` is on, but the actions behind it didn't check that setting. - `ThemeEdit`, `Templates`, `TemplateEdit` and `StylesheetEdit` return the setting from `isFeatureEnabled()`, so `UISecurityInterceptor` treats them the way the menu does. `Templates` also covers its add/remove subactions. - The XML-RPC `blogger.setTemplate` call checks the same setting. `getTemplate` is unchanged. - Weblogs that already use custom templates keep rendering them. CHANGES notes the behaviour change under 6.1.8. Tests: `DesignPagesFeatureTest` checks the four actions with the setting on and off. `XMLRPCWeblogPermissionTest` turns the setting on for its existing checks and adds one for `setTemplate` with it off. Both fail on `roller-6.1.x` and pass here. `mvn -pl app test`: 500 tests, 0 failures. Once this is merged, the same change goes to master for 7.0.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
