mraible opened a new pull request, #279: URL: https://github.com/apache/roller/pull/279
When a shared theme's `theme.xml` names a preview image that isn't there, `SharedTheme.getPreviewImage()` is null (Roller already logs "Couldn't read theme [...] preview image file" at startup), and `ThemeDataServlet` called `getPath()` on it. `/roller-ui/authoring/themedata?theme=<id>` answered 500, so the Theme and Create Weblog pages didn't show that theme's description, and the list form (no `theme` parameter) failed for every theme. - The servlet now sends `"previewPath": null` for such a theme. The startup warning stays, since the theme is still missing a file. - The Theme and Create Weblog pages hide the thumbnail when there's no preview path, instead of requesting `<siteURL>null`. - `ThemeDataServletTest` covers one theme, the list, and a theme with a preview; two of its three tests fail with the NullPointerException without the fix. Found on a copy of raibledesigns.com, whose `andreas08` theme names `sm-theme-andreas08.png` but doesn't include it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
