mraible opened a new pull request, #290: URL: https://github.com/apache/roller/pull/290
The Emoticons plugin replaced emoticons anywhere in an entry's HTML, including inside tags. On a copy of raibledesigns.com, nine posts with Instagram embeds have an SVG with `xmlns:xlink=...`, and its `:x` became an emoji, breaking the markup. Roller 5 broke the same spot with a GIF, so this isn't a regression from #266, but it's still wrong. - `SmileysPlugin`'s single-pass pattern now also matches an HTML comment or tag (`<` followed by a letter, `/` or `!`, up to `>`) and copies it unchanged, so only text between tags is replaced. - A plain `<` in text, as in `1 < 2 :-)`, isn't treated as a tag, so the emoticon after it still converts. - `SmileysPluginTest` covers the SVG case, an attribute holding `:-)`, a comment, and the `<` case; the SVG test fails without the fix. - CHANGES.md gets a line under the fixes found while upgrading a 6.1 site. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
