mraible opened a new pull request, #293: URL: https://github.com/apache/roller/pull/293
Every Roller action is declared in `struts.xml`, and nothing in the codebase uses the Convention plugin's annotations (the `@AllowedMethods` ones are commented out). This turns off the plugin's package scanning with `struts.convention.action.disableScanning=true`, so `struts.xml` is the only source of action mappings. - New `StrutsActionMappingTest` loads the Struts configuration the webapp uses (`struts.xml`, `struts.properties` and the plugins on the classpath) and checks that actions exist only in the five `struts.xml` namespaces. Without the property it also finds `/admin`, `/core`, `/editor` and `/util`. - Saxon is excluded from jing's test dependencies. Jing pulls in Saxon 8.7, whose `TransformerFactory` can't load Struts' configuration, and jing only uses it for Schematron, which Roller doesn't use. - `mvn install` passes on JDK 21 (732 tests, 1 skipped). I haven't run the Playwright UI tests locally. The same change for 6.1.x is in #61X_PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
