mraible opened a new pull request, #297: URL: https://github.com/apache/roller/pull/297
Comments longer than `comment.maxLength` characters, 10,000 by default, are now refused with a message before they are previewed or checked by the comment validators. The property is in `roller.properties`, so sites can change it in `roller-custom.properties`. Comment content is stored as `TEXT`, which MySQL limits to 65,535 bytes, so 10,000 characters is always storable. The bundled `bannedwordslist.txt` rules match the same domains as before, but each now looks at most 63 characters (the longest DNS label) between its parts, so the time to check a comment grows in step with its length. The first rule's optional subdomain prefix is dropped because it didn't change whether the rule matches. A site with its own copy of the file in the uploads directory keeps using that copy. - `BannedwordslistTest` checks that each bundled rule still matches a sample of the domains it targets, and that long text is checked within a time limit. The old rules exceed it; the new ones take a few milliseconds. - New `CommentServletTest` covers the length check and the shipped default. - `mvn install` passes on JDK 11 (516 tests, 1 skipped), and the it-selenium tests pass. - CHANGES has an entry under "Behaviour changes worth reading before upgrading". The same change for master is in #OTHER. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
