mraible commented on PR #300: URL: https://github.com/apache/roller/pull/300#issuecomment-6933445944
Tested against a real site's data: master with this PR merged (84b6dc340), behind Apache httpd and a TLS-terminating proxy, with two `security.access` properties replacing the site's hand edit of `security.xml` to keep one weblog private for a role. All logins below were scripted with curl, not a browser. - **Private weblog:** anonymous requests get 302 to the login page, a user without the role gets 403, and a member gets 200, for the weblog and its feed. The rules apply to other casings of its path as well. - **Proxy:** redirects to the login page and back to the saved request keep the forwarded scheme and host, and `JSESSIONID` is `Secure` and `HttpOnly`. - **Login form:** a POST to `/roller_j_security_check` without `_csrf` gets 403. With the token read from `login.rol` in the same session, member and non-member logins work. A wrong password gets 302 to `login.rol?error=true` without the remember-me cookie-clearing header that RC1 sends, the one expected difference. - **Sessions and caching:** ten anonymous pages and feeds (home, entry pages with comment forms, Atom and RSS feeds, tag, category, search) set no cookie, and weblog pages and feeds still send `Last-Modified` without `Cache-Control`. - **Comments:** anonymous comment preview and post aren't refused by the security chain and set no cookie. - **Baseline:** all 18,597 addresses from the site's baseline matched RC1 in status, `Location`, cookie names, `Content-Type` and `Cache-Control` on 0ced33c30, and a 1,741-address sample matched again on 84b6dc340. Not covered: remember-me with the box ticked, logout, AtomPub, XML-RPC, OIDC and a browser. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
