mraible commented on PR #301:
URL: https://github.com/apache/roller/pull/301#issuecomment-6933916918

   Tested at f69e6f921 on a copy of a real site whose accounts still have 
40-character unprefixed SHA-1 hashes: built alone on master, MySQL 8.4, 
`passwds.encryption.enabled=true`, `algorithm=bcrypt`, `lazyUpgradeFrom=SHA`, 
logging in through the form behind Apache httpd and a TLS proxy. Stored values 
were compared by format, length and a fingerprint, never read.
   
   - Wrong password for two accounts on SHA-1: 302 to `login.rol?error=true`, 
and both rows unchanged.
   - First successful login for an account with an unprefixed lowercase SHA-1 
hash: the row became a 68-character `{bcrypt}` hash, and the log shows "Stored 
the re-encoded password of …" once at INFO.
   - Second login for that account works, and the row isn't rewritten.
   - An account already on `{bcrypt}` logs in, and its row is unchanged.
   - An account that didn't log in keeps its SHA-1 hash, and the log has no 
SEVERE or ERROR lines.
   
   Not covered: XML-RPC and AtomPub logins (they verify old hashes but don't 
re-hash them), and the `noop` cases, which `PasswordUpgradeTest` covers. Logins 
were scripted with curl, and the upgraded account used a test password stored 
in the old format.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to