mraible opened a new pull request, #306: URL: https://github.com/apache/roller/pull/306
The 6.1.x version of #304. Users who log in through LDAP or the servlet container have `users.passwords.externalAuthValue` (by default `<externalAuth>`) stored in place of a Roller password. `RollerContext` now wraps its password encoder in a new `ExternalLoginAwarePasswordEncoder`, whose `matches()` never accepts that placeholder, wherever Roller checks a password with the encoder. Encoding and `upgradeEncoding` are unchanged, and stored passwords aren't touched. This line builds for Java 11, so the wrapper is a class rather than the record #304 uses, and `RollerContext.encoder` is now typed as `PasswordEncoder`. - `ExternalLoginAwarePasswordEncoderTest` checks that the placeholder doesn't match, encoded or unencoded, and that other passwords (bcrypt and plaintext) still do. - `mvn test` passes on JDK 21 (534 tests, 1 skipped, the same as the branch). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
