mraible opened a new pull request, #309: URL: https://github.com/apache/roller/pull/309
Removes two Struts actions that no page links to, with their tiles and JSPs: - `mediaFileImageDim` (`MediaFileImageDim`, `.MediaFileImageDimension`, `MediaFileImageDimension.jsp`) - the overlay `mediaFileAdd` in `/roller-ui/authoring/overlay`, with its `.MediaFileAddInclude` and `.MediaFileAddSuccessInclude` tiles and `MediaFileAddSuccessInclude.jsp`. The regular `mediaFileAdd` and `MediaFileAdd.jsp` stay. The entry editor and the category page insert media through the overlay `mediaFileImageChooser`, which uses each file's permalink (`MediaFileCard.jsp`), and the upload result page does the same. The two removed JSPs built `/roller-ui/rendering/media-resources/<id>` links, which Roller answers with 404 because the request parser takes the first path element as the weblog handle; the overlay add page also never set the new file's ID on its bean. - `AuthoringActionScopingTest` drops its `MediaFileImageDim` case and keeps the `EntryAddWithMediaFile` one. - `mvn test` passes (749 tests), and the Playwright database-login suite passes against `jetty:run` (20 run, 3 OIDC tests skipped), including the media library tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
