snoopdave commented on code in PR #333:
URL: https://github.com/apache/roller/pull/333#discussion_r4608375248


##########
app/src/main/java/org/apache/roller/weblogger/ui/struts2/core/Profile.java:
##########
@@ -122,6 +128,8 @@ public String save() {
                 UserManager mgr = 
WebloggerFactory.getWeblogger().getUserManager();
                 mgr.saveUser(existingUser);
                 WebloggerFactory.getWeblogger().flush();
+                // a password change ends the user's other sessions, not this 
one
+                RollerSession.refreshPassword(getServletRequest(), 
existingUser);

Review Comment:
   **Important:** In OPENID and DB_OPENID mode, `save()` generates a new random 
password hash on every profile save. The new digest check therefore ends the 
user's other sessions even when they only edit a name or locale. 
`UserEdit.save()` has the same behavior. Keep the existing placeholder when no 
credential changes, and add a test for an OpenID profile edit without a 
password change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to