mraible commented on PR #322: URL: https://github.com/apache/roller/pull/322#issuecomment-6968821710
A second review raised a few more points, now addressed in the latest commits: - A disabled user who holds ADMIN no longer counts as the weblog's remaining administrator when resigning or saving members, covered by a new WeblogMembershipTest case. - Removing a weblog or a user now also removes its pending invitations, so a weblog or user created again with the same name starts without them; PermissionTest covers both. - When the 256-character limit cuts a quoted phrase, the search request now drops that phrase's opening quote so the rest of the query still parses; a query Lucene can't parse was already caught and finds nothing. SearchQueryLengthTest covers both a cut and an intact phrase. - No change here for DB_OIDC profile saves: replacing the stored password of an account with a federated identity predates this PR, which only takes that identity from the stored user instead of the form, and keeping the stored password on Profile and UserEdit saves is handled in #321. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
