mraible commented on code in PR #321:
URL: https://github.com/apache/roller/pull/321#discussion_r4609096057
##########
app/src/main/java/org/apache/roller/weblogger/ui/struts2/core/Profile.java:
##########
@@ -124,6 +125,8 @@ public String save() {
UserManager mgr =
WebloggerFactory.getWeblogger().getUserManager();
mgr.saveUser(existingUser);
WebloggerFactory.getWeblogger().flush();
+ // a password change ends the user's other sessions, not this
one
+ RollerSession.refreshPassword(getServletRequest(),
existingUser);
Review Comment:
Profile.save and UserEdit.save now generate a stored password for OIDC and
DB_OIDC accounts only when the account has none or its OpenID URL changes, so a
profile-only edit keeps the user's other sessions. PasswordChangeSessionTest
covers an OIDC profile edit and an administrator edit with a second session
open (both failed before the change), plus switching an account to an OpenID
URL, which still replaces the stored password.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]