mraible commented on PR #320: URL: https://github.com/apache/roller/pull/320#issuecomment-6968820663
A second review raised a few more points, now addressed in the latest commits: - Emails no longer use the request's host: while site.absoluteurl is unset, comment and approval notifications are sent without their links, and activation, invitation and pending-entry emails, which exist to deliver a link, aren't sent (activation and invitation report why, the pending-entry notice logs a warning). Dropping the links keeps comment moderation mail flowing; MailUtilSiteUrlTest covers all five with a request on another host. - The planet sync task and the local weblog feed fetcher now skip their work until site.absoluteurl is set, instead of storing subscriptions and entries with incomplete links; PlanetSiteUrlTest covers both. - The installer, first-admin registration and admin-request paths no longer save a URL whose host is loopback, private, link-local, *.localhost/*.local or a single label such as localhost or a proxy backend name; those are left for an administrator to set. SiteUrlForAdminTest covers the rejected and accepted hosts. - I left the cache bound as is: the rendering caches are fixed-size LRUs (400 page, 200 feed, 50 site-wide, 10 planet entries), and their keys already include request-chosen values such as tags, dates and page numbers, so varying the Host adds no new way to evict entries or use memory. Per-host keys also only apply until the URL is set, and the cached entries are cleared when it is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
