mraible commented on code in PR #318:
URL: https://github.com/apache/roller/pull/318#discussion_r4609097725
##########
app/src/main/webapp/WEB-INF/velocity/feeds.vm:
##########
@@ -32,7 +32,7 @@
<entry>
<id>$entry.permalink</id>
<title type="html">$utils.escapeXML($entry.title)</title>
- <author><name>$entry.creator.screenName</name></author>
+
<author><name>$utils.escapeXML($utils.unescapeHTML($entry.creator.screenName))</name></author>
Review Comment:
showCommentsAtom10 and showCommentsRSS20 now use unescapeHTML before
escapeXML, like the entry authors, and the media file feed author does the same
since screen names can be stored already encoded. FeedAuthorEscapingTest now
covers both comment feeds and the media file feed, with names like "A & B" and
"<b>Bold</b>".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]