mraible opened a new pull request, #354:
URL: https://github.com/apache/roller/pull/354

   The comment plugin checkbox list on Server Admin > Configuration set 
`value="name"`, which doesn't evaluate to the enabled plugin ids. Every box 
showed unchecked, even HTMLSubset, the default. Saving the page for any reason 
then stored an empty `users.comments.plugins`, which turned off HTMLSubset and 
every other comment plugin site-wide.
   
   - On master and roller-6.1.x, HTML comments are escaped when HTMLSubset 
doesn't run, so they showed as escaped markup.
   - In 6.1.7, which escapes only text/plain comments, HTML comments were shown 
unfiltered once HTML comments were allowed.
   
   Without the `value` attribute, the list checks the plugins in 
`commentPlugins`, which the action loads from `users.comments.plugins`. The bug 
dates from e83e5f811 (2018).
   
   NewUserJourneyIT saves this page to enable uploads. It now checks that 
HTMLSubset is checked before and after the save. It failed before the fix 
(HTMLSubset unchecked on a fresh site) and passes after; the db-mode UI suite 
passes (20 tests, the 3 OIDC tests skipped).
   
   The 6.1.x fix is a separate PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to