mraible commented on code in PR #334:
URL: https://github.com/apache/roller/pull/334#discussion_r4637220159
##########
app/src/main/java/org/apache/roller/weblogger/ui/struts2/editor/Members.java:
##########
@@ -112,31 +118,40 @@ public String save() {
error = true;
}
// one iteration for each line (user) in the members table
+ Map<String, List<String>> changes = new LinkedHashMap<>();
for (WeblogPermission perms : permsList) {
- String sval = getParameter("perm-" + perms.getUser().getId());
+ User member = perms.getUser();
+ if (member == null) {
Review Comment:
The Members page now keys each row by its permission (`perm-<permission
id>`) and shows the permission's user name, so `save()` no longer calls
`getUser()` and an admin can remove a disabled member or change their role,
with `updateWeblogMembership()` doing the rest. I added
`membersPageRemovesADisabledMember` and
`membersPageChangesADisabledMembersRole` to `WeblogMembershipTest`, and
re-keyed the existing page tests to the new field names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]