"change" event is being used widely in the framework, but in that case definitely more suites name "selectedDateChanged".
Thanks! 2017-11-01 0:30 GMT+01:00 Harbs <harbs.li...@gmail.com>: > Nope. > > Copying my response from Github: > > The only place change is referenced in the Framework is in the metadata of > DateChooser: > [Event(name="change", type="org.apache.royale.events.Event")] > > That could easily be changed to: > [Event(name="selectedDateChanged", type="org.apache.royale.events.Event")] > > The current metadata is actually incorrect, because the event type is > org.apache.royale.events.BrowserEvent > > Harbs > > > On Nov 1, 2017, at 1:29 AM, Piotr Zarzycki <piotrzarzyck...@gmail.com> > wrote: > > > > You can remove it if it is not fired it up for some other cases in > > DateChooser. > > > > Piotr > > > > 2017-11-01 0:23 GMT+01:00 Harbs <harbs.li...@gmail.com>: > > > >> My comment in the commit message needs discussion. > >> > >> I think the change event should be removed. What do others think? > >> > >> Harbs > >> > >>> On Nov 1, 2017, at 1:14 AM, ha...@apache.org wrote: > >>> > >>> This is an automated email from the ASF dual-hosted git repository. > >>> > >>> harbs pushed a commit to branch develop > >>> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git > >>> > >>> > >>> The following commit(s) were added to refs/heads/develop by this push: > >>> new 2072541 Fixes #24 > >>> 2072541 is described below > >>> > >>> commit 2072541f1f9da5ed1780d497a6ec5fab52674b91 > >>> Author: Harbs <ha...@in-tools.com> > >>> AuthorDate: Wed Nov 1 01:14:29 2017 +0200 > >>> > >>> Fixes #24 > >>> > >>> I’m not sure why we’re dispatching both a “selctedDateChanged” event > >> and a “changed” event for the same action. It seems like we should > dispatch > >> one or the other. > >>> On the one hand, “change” is a standard name, so it’s easily > >> discoverable. On the other hand, “change” is one of the special events > >> which become BrowserEvents when dispatched. > >>> I think the change event should be removed. > >>> --- > >>> .../org/apache/royale/html/beads/DateChooserView.as | 16 > >> ++++++++++++---- > >>> .../html/beads/controllers/DateChooserMouseController.as | 1 - > >>> 2 files changed, 12 insertions(+), 5 deletions(-) > >>> > >>> diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/ > >> royale/html/beads/DateChooserView.as b/frameworks/projects/Basic/ > >> src/main/royale/org/apache/royale/html/beads/DateChooserView.as > >>> index 2316f4a..17a5ef0 100644 > >>> --- a/frameworks/projects/Basic/src/main/royale/org/apache/ > >> royale/html/beads/DateChooserView.as > >>> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/ > >> royale/html/beads/DateChooserView.as > >>> @@ -86,6 +86,13 @@ package org.apache.royale.html.beads > >>> private var daysContainer:DateChooserList; > >>> > >>> /** > >>> + * @royaleignorecoercion org.apache.royale.core.UIBase > >>> + */ > >>> + private function getHost():UIBase > >>> + { > >>> + return _strand as UIBase; > >>> + } > >>> + /** > >>> * The button that causes the previous month to be > >> displayed by the DateChooser. > >>> * > >>> * @langversion 3.0 > >>> @@ -171,7 +178,7 @@ package org.apache.royale.html.beads > >>> _nextMonthButton.style.flexGrow = 0; > >>> monthButtonsContainer. > >> addElement(_nextMonthButton); > >>> > >>> - UIBase(_strand).addElement( > monthButtonsContainer, > >> false); > >>> + getHost().addElement(monthButtonsContainer, > >> false); > >>> > >>> // DAY NAMES > >>> > >>> @@ -188,7 +195,7 @@ package org.apache.royale.html.beads > >>> COMPILE::SWF { > >>> dayNamesContainer.percentWidth = 100; > >>> } > >>> - UIBase(_strand).addElement(dayNamesContainer, > >> false); > >>> + getHost().addElement(dayNamesContainer, false); > >>> > >>> // DAYS > >>> > >>> @@ -203,7 +210,7 @@ package org.apache.royale.html.beads > >>> COMPILE::SWF { > >>> daysContainer.percentWidth = 100; > >>> } > >>> - UIBase(_strand).addElement(daysContainer, > false); > >>> + getHost().addElement(daysContainer, false); > >>> > >>> > >>> IEventDispatcher(daysContainer).dispatchEvent( > >> new Event("itemsCreated") ); > >>> @@ -233,7 +240,8 @@ package org.apache.royale.html.beads > >>> var index:Number = model.getIndexForSelectedDate( > >> ); > >>> daysContainer.selectedIndex = index; > >>> > >>> - IEventDispatcher(_strand).dispatchEvent(new > >> Event("selectedDateChanged")); > >>> + getHost().dispatchEvent(new > >> Event("selectedDateChanged")); > >>> + getHost().dispatchEvent( new Event("change") ); > >>> } > >>> > >>> /** > >>> diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/ > >> royale/html/beads/controllers/DateChooserMouseController.as > >> b/frameworks/projects/Basic/src/main/royale/org/apache/ > >> royale/html/beads/controllers/DateChooserMouseController.as > >>> index d3ef05c..ccf3cbc 100644 > >>> --- a/frameworks/projects/Basic/src/main/royale/org/apache/ > >> royale/html/beads/controllers/DateChooserMouseController.as > >>> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/ > >> royale/html/beads/controllers/DateChooserMouseController.as > >>> @@ -81,7 +81,6 @@ package org.apache.royale.html.beads.controllers > >>> var list:DateChooserList = event.target as DateChooserList; > >>> var model:DateChooserModel = _strand.getBeadByType( > IBeadModel) > >> as DateChooserModel; > >>> model.selectedDate = list.selectedItem as Date; > >>> - IEventDispatcher(_strand).dispatchEvent( new > >> Event("change") ); > >>> } > >>> > >>> /** > >>> > >>> -- > >>> To stop receiving notification emails like this one, please contact > >>> ['"comm...@royale.apache.org" <comm...@royale.apache.org>']. > >> > >> > > > > > > -- > > > > Piotr Zarzycki > > > > mobile: +48 880 859 557 > > skype: zarzycki10 > > > > LinkedIn: http://www.linkedin.com/piotrzarzycki > > <https://pl.linkedin.com/in/piotr-zarzycki-92a53552> > > > > GitHub: https://github.com/piotrzarzycki21 > > -- Piotr Zarzycki mobile: +48 880 859 557 skype: zarzycki10 LinkedIn: http://www.linkedin.com/piotrzarzycki <https://pl.linkedin.com/in/piotr-zarzycki-92a53552> GitHub: https://github.com/piotrzarzycki21
