Maybe. I didn’t realize changing the typedefs was going to end up being so 
complicated.

I just changed the ant build to use git instead of svn. It takes about a minute 
the first time the repo is needed to be downloaded, but it’s pretty quick 
afterwards.

I’m not sure which method is best for Maven.

> On Feb 13, 2018, at 2:17 PM, Piotr Zarzycki <[email protected]> wrote:
> 
> Btw. Maybe you should move your changes to separate branch. We will have
> emails with fails for a long time now. Unless someone else look into the
> Maven.
> 
> 2018-02-13 13:03 GMT+01:00 Gabe Harbs <[email protected] 
> <mailto:[email protected]>>:
> 
>> FWIW, here’s some other options for downloading a specific folder from
>> Github:
>> https://stackoverflow.com/a/18194523
>> 
>>> On Feb 13, 2018, at 1:57 PM, Gabe Harbs <[email protected]> wrote:
>>> 
>>> If you use Git, you need to download the entire repo which includes all
>> the bits for the actual compiler.
>>> 
>>> Github supports svn checkouts as well which allows you to checkout a
>> specific folder within a repo.[1]
>>> 
>>> The following command will get the extern files we need from Github:
>>> 
>>> svn checkout https://github.com/royale-extras/closure-compiler/
>> branches/royale/externs <https://github.com/royale- 
>> <https://github.com/royale->
>> extras/closure-compiler/branches/royale/externs>
>>> 
>>> Harbs
>>> 
>>> [1]https://help.github.com/articles/support-for-subversion-clients/ 
>>> <https://help.github.com/articles/support-for-subversion-clients/> <
>> https://help.github.com/articles/support-for-subversion-clients/ 
>> <https://help.github.com/articles/support-for-subversion-clients/>>
>>> 
>>>> On Feb 13, 2018, at 1:54 PM, Piotr Zarzycki <[email protected] 
>>>> <mailto:[email protected]>
>> <mailto:[email protected] <mailto:[email protected]>>> wrote:
>>>> 
>>>> Actually why are you talking about svn ? You mean GIT actually ?
>>>> 
>>>> 2018-02-13 12:47 GMT+01:00 Gabe Harbs <[email protected] 
>>>> <mailto:[email protected]> <mailto:
>> [email protected] <mailto:[email protected]>>>:
>>>> 
>>>>> BTW, there’s a mojo for svn checkout:
>>>>> https://maven.apache.org/scm/maven-scm-plugin/checkout-mojo.html 
>>>>> <https://maven.apache.org/scm/maven-scm-plugin/checkout-mojo.html> <
>> https://maven.apache.org/scm/maven-scm-plugin/checkout-mojo.html 
>> <https://maven.apache.org/scm/maven-scm-plugin/checkout-mojo.html>> <
>>>>> https://maven.apache.org/scm/maven-scm-plugin/checkout-mojo.html 
>>>>> <https://maven.apache.org/scm/maven-scm-plugin/checkout-mojo.html> <
>> https://maven.apache.org/scm/maven-scm-plugin/checkout-mojo.html 
>> <https://maven.apache.org/scm/maven-scm-plugin/checkout-mojo.html>>>
>>>>> 
>>>>> Maybe you can use that.
>>>>> 
>>>>> Harbs
>>>>> 
>>>>>> On Feb 13, 2018, at 1:41 PM, Gabe Harbs <[email protected] 
>>>>>> <mailto:[email protected]>
>> <mailto:[email protected] <mailto:[email protected]>>> wrote:
>>>>>> 
>>>>>> We need to download all the files from here:
>> https://github.com/royale- <https://github.com/royale-> 
>> <https://github.com/royale- <https://github.com/royale->>
>>>>> extras/closure-compiler/tree/royale/externs/ <
>> https://github.com/royale- <https://github.com/royale-> 
>> <https://github.com/royale- <https://github.com/royale->>
>>>>> extras/closure-compiler/tree/royale/externs/> to js/target/downloads.
>>>>>> 
>>>>>> Svn seems like the easiest way to do that, but you can use any method
>>>>> that works.
>>>>>> 
>>>>>> Harbs
>>>>>> 
>>>>>>> On Feb 13, 2018, at 1:39 PM, Piotr Zarzycki <
>> [email protected] <mailto:[email protected]> 
>> <mailto:[email protected] <mailto:[email protected]>>
>>>>> <mailto:[email protected] <mailto:[email protected]> 
>>>>> <mailto:[email protected] <mailto:[email protected]>>>>
>> wrote:
>>>>>>> 
>>>>>>> Can we avoid using svn ? Or it was used before ? I'm not familiar
>> with
>>>>> that
>>>>>>> logic.
>>>>>>> 
>>>>>>> 2018-02-13 12:37 GMT+01:00 Harbs <[email protected] 
>>>>>>> <mailto:[email protected]> <mailto:
>> [email protected] <mailto:[email protected]>> <mailto:
>>>>> [email protected] <mailto:[email protected]> <mailto:[email protected] 
>>>>> <mailto:[email protected]>>>>:
>>>>>>> 
>>>>>>>> We need to add svn checkout of the externs like I did in the ant
>>>>> script.
>>>>>>>> 
>>>>>>>>> On Feb 13, 2018, at 1:36 PM, Apache Jenkins Server <
>>>>>>>> [email protected] <mailto:[email protected]> 
>>>>>>>> <mailto:[email protected] <mailto:[email protected]>>
>> <mailto:[email protected] <mailto:[email protected]> 
>> <mailto:[email protected] <mailto:[email protected]>>>>
>> wrote:
>>>>>>>>> 
>>>>>>>>> The Apache Jenkins build system has built Royale-typedefs (build
>> #34)
>>>>>>>>> 
>>>>>>>>> Status: Failure
>>>>>>>>> 
>>>>>>>>> Check console output at https://builds.apache.org/job/ 
>>>>>>>>> <https://builds.apache.org/job/> <
>> https://builds.apache.org/job/ <https://builds.apache.org/job/>> <
>>>>> https://builds.apache.org/job/ <https://builds.apache.org/job/> 
>>>>> <https://builds.apache.org/job/ <https://builds.apache.org/job/>>>
>>>>>>>> Royale-typedefs/34/ to view the results.
>>>>>>>> 
>>>>>>>> 
>>>>>>> 
>>>>>>> 
>>>>>>> --
>>>>>>> 
>>>>>>> Piotr Zarzycki
>>>>>>> 
>>>>>>> Patreon: *https://www.patreon.com/piotrzarzycki 
>>>>>>> <https://www.patreon.com/piotrzarzycki> <
>> https://www.patreon.com/piotrzarzycki 
>> <https://www.patreon.com/piotrzarzycki>> <
>>>>> https://www.patreon.com/piotrzarzycki 
>>>>> <https://www.patreon.com/piotrzarzycki> <https://www.patreon.com/ 
>>>>> <https://www.patreon.com/>
>> piotrzarzycki>>
>>>>>>> <https://www.patreon.com/piotrzarzycki 
>>>>>>> <https://www.patreon.com/piotrzarzycki> <https://www.patreon.com/ 
>>>>>>> <https://www.patreon.com/>
>> piotrzarzycki> <https://www.patreon.com/ <https://www.patreon.com/> 
>> <https://www.patreon.com/ <https://www.patreon.com/>>
>>>>> piotrzarzycki>>*
>>>>>> 
>>>>> 
>>>>> 
>>>> 
>>>> 
>>>> --
>>>> 
>>>> Piotr Zarzycki
>>>> 
>>>> Patreon: *https://www.patreon.com/piotrzarzycki 
>>>> <https://www.patreon.com/piotrzarzycki> <
>> https://www.patreon.com/piotrzarzycki 
>> <https://www.patreon.com/piotrzarzycki>>
>>>> <https://www.patreon.com/piotrzarzycki 
>>>> <https://www.patreon.com/piotrzarzycki> <https://www.patreon.com/ 
>>>> <https://www.patreon.com/>
>> piotrzarzycki>>*
>>> 
>> 
>> 
> 
> 
> -- 
> 
> Piotr Zarzycki
> 
> Patreon: *https://www.patreon.com/piotrzarzycki 
> <https://www.patreon.com/piotrzarzycki>
> <https://www.patreon.com/piotrzarzycki 
> <https://www.patreon.com/piotrzarzycki>>*

Reply via email to